The point of the exercise is not to just find a bug, but use mypy to do that. Could you please add types to this file and others as well? You will need to add mypy to requirements.

Thanks for the review. I have already added type annotations to all functions in this file and other related files and used mypy to check for type consistency. The mypy check shows Success: no issues found.
I realized I had forgotten to include mypy in requirements.txt, but I’ve now added it so it will be installed automatically.

I think the readability could be improved if you use date arithmetics here, for example (assuming today = date.today())

date(
        today.year - 18,
        today.month,
        today.day
    )

and compare it with the date of birth

i tried to follow your suggestion and made changes.

I would consider throwing a value error here and using try/catch block instead.

Thank you, try to follow your suggestion and made changes

Optional: you can consider using ruff to improve your code formatiing, something like:

pip install ruff
ruff format .

I will do it definitely.

Did you get a chance to check this out?

Instead of adding comments, try to see where it make sense to group these various bits of logic into methods with descriptive names.

I try to make changes and use different function

Thanks! In general, apart from invoking the main method, all the logic needs to be part of some method / class. The clarity should be coming from the name of the methods and structure of the code rather than comments explaining what you are doing (those could be useful too in some cases but should not be used as a substitute for clear structure and naming).

That said, from what I see this is more like a hands-on exercise to practice some concepts so it is ok your code has less structure.

You should design it in a way that doesn't require you to go through all possible values manually. Imagine your OperatingSystem enum containing 50 different systems. Try to use, for example, a dict structure.

i tried to follow your suggestion

In python, the naming convention for files is snake_case

sorry, I changed them thank you

Did you get a chance to check this out?

Did you want to add this as a standalone method or as a part of the class?

Thank you for the feedback. Yes, is_adult should be a method inside the Person class. I accidentally placed it outside. I’ll move it inside the class so it can be called as person.is_adult().

Formatting is a bit off in places which makes the code slightly harder to read. Using ruff or other auto formatters might help with readability (e.g. int)-> missing space)

Thank you I installed ruff and did it.

Thanks! In general, apart from invoking the main method, all the logic needs to be part of some method / class. The clarity should be coming from the name of the methods and structure of the code rather than comments explaining what you are doing (those could be useful too in some cases but should not be used as a substitute for clear structure and naming).

That said, from what I see this is more like a hands-on exercise to practice some concepts so it is ok your code has less structure.

Just a comment (no need to fix) - you to made it case insensitive so it works (all good), but overall you could also use https://docs.python.org/3/library/enum.html#enum.EnumType.__getitem__

Thanks for the note!I’ll keep that in mind for future refactoring.

Just for you information, an alternative approach could also be

return [
        laptop for laptop in laptops 
        if laptop.operating_system == person.preferred_operating_system
    ]

Thanks for the suggestion! yes a list comprehension is more concise and readable